Conversation
- added test_weights_2d - interpolate marked as failing
Removing vaex.vaexfast.Error in favor of using std errors
Adressing:
/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/site-packages/vaex/strings.py:10: in <module>
from .superstrings import *
E ImportError: libpcrecpp.so.0: cannot open shared object file: No such file or directory
…merge supposed to do here
|
ddelange
left a comment
There was a problem hiding this comment.
awesome, thanks for the quick action!
|
This looks great! @maartenbreddels : Thoughts on getting this in? |
|
@maartenbreddels kind reminder:) |
|
@maartenbreddels : Realize there's a lot going on but would really be helpful if you could help with getting this in. It closes a bunch of open issues and |
|
@maartenbreddels kind reminder :) |
|
@maartenbreddels kind reminder here. I've reviewed and this looks good to me. |
|
@maartenbreddels can you please merge this PR? |
|
Looks good! Lets see if it's still green when merged :) |
|
looks like only some rot in 801 commits since the last release... including numpy v2 support! |
|
@2maz can 25cf41a be reverted? now that catboost 1.2.8 has been released, vaex's ci is allowed to install numpy v2 (catboost/catboost@b6fd136) hence causing the crash as per 25cf41a |
|
@ddelange yes, we can now operate with catboost>=1.2.8 One new windows issue seems to have appeared https://github.com/2maz/vaex/actions/runs/17110604988/job/48530848114#step:11:880 |
|
awesome, thanks for looking into this! super interesting that such a simple sum can consistently give a wrong result on windows only, especially because it was green before 🤔 |
FYI: this particular one turned out to be a pyarrow 21.0.0 issue in fill_null - until fixed we need to restrict to pyarrow<21.0.0 for windows |
|
Thank you so much for solving this issue and merging this guys! |
|
Final touches in #2463 @ddelange @maartenbreddels |
update: this will be fixed in arrow v22. |
vaex - vaexio/vaex#2449 spark - supports numpy 2 as of version 4.0.0
vaex - vaexio/vaex#2449 spark - supports numpy 2 as of version 4.0.0
This pull request intends to enable the use of numpy2 (#2446 #2425) with vaex.
In addition it applies some other fixes.
An (incomplete) summary:
Note, that I encountered some broken test(s) in cmodule.py test_interpolate and those related to Webserver:
Some format changes from tab to space indent have been applied.
Please let me know if (further) changes are required - only validated on Linux system right now.
I ran tests in vaex-core/vaex/test - any more instructions on how to run you full test-suite (apart from ci)?
Thx.
@maartenbreddels @ddelange