Drop python 3.8, add python 3.13, allow numpy 2.x#2446
Closed
ddelange wants to merge 1 commit intovaexio:masterfrom
Closed
Drop python 3.8, add python 3.13, allow numpy 2.x#2446ddelange wants to merge 1 commit intovaexio:masterfrom
ddelange wants to merge 1 commit intovaexio:masterfrom
Conversation
Contributor
Author
|
not sure if build fails fast on the first error (probably), but apart from a bunch of notes and warnings, here's our first candidate: src/vaexfast.cpp:2045:63: error: cannot convert ‘PyObject*’
{aka ‘_object*’} to ‘const PyArrayObject*’ {aka ‘const
tagPyArrayObject_fields*’}
2045 | new_array_ptr =
(double*)PyArray_DATA(new_array); |
4 tasks
|
I'm guessing you meant "Drop Python 3.8" and not 3.9? |
Contributor
Author
|
Thanks, adjusted the PR title 👍 |
Merged
Contributor
Author
|
superceded by #2449 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
help wanted! this is failing and I don't have time to debug.
for python 3.13 support, the build system needs to be compatible with numpy 2.1
despite buildtime needing numpy 2.x, the runtime dependency can theoretically still allow numpy 1.x (see diff).
close #2425
ref scipy/oldest-supported-numpy#86