Skip to content

CI: change publish step condition#6181

Merged
sylvestre merged 1 commit intouutils:mainfrom
tertsdiepraam:lets-fix-this-bleeping-release
Apr 2, 2024
Merged

CI: change publish step condition#6181
sylvestre merged 1 commit intouutils:mainfrom
tertsdiepraam:lets-fix-this-bleeping-release

Conversation

@tertsdiepraam
Copy link
Copy Markdown
Collaborator

Hopefully, this fixes our release artifact problems.

Based on: https://github.com/marketplace/actions/gh-release#-limit-releases-to-pushes-to-tags

Hopefully, this fixes our release artifact problems.
@sylvestre
Copy link
Copy Markdown
Contributor

let's see

@rivy
Copy link
Copy Markdown
Contributor

rivy commented Apr 24, 2024

@tertsdiepraam , @sylvestre , unfortunately, this doesn't appear to fix the issue.

I believe that the CICD.yaml config instead just needs to trigger for all tags.
If so, the config is just slightly wrong.
If I'm correct it'll be a one line change.

...

With the change, it's now testing as correct on a test clone.

I've opened a PR with the fix.
I have included a reversion of this commit so that only version-type tags will trigger release deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants