fix/CI ~ re-enable artifact deployment for version tagged commits#6270
Merged
sylvestre merged 2 commits intouutils:mainfrom Apr 24, 2024
Merged
fix/CI ~ re-enable artifact deployment for version tagged commits#6270sylvestre merged 2 commits intouutils:mainfrom
sylvestre merged 2 commits intouutils:mainfrom
Conversation
This was referenced Apr 24, 2024
Contributor
|
excellent, thanks :) |
Collaborator
|
Welcome back @rivy ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple one-line fix of CICD.yaml to re-enable artifact creation for version tagged commits.
It does include a revert of #6181 so that only version-type tags trigger deployment.
I've done testing on a repo clone, so I'm 90% confident. 😄
If it doesn't work on the next release, ping me and I'll further debug it.
@sylvestre , the deployment does always create a release even if there's a draft release with the same title/version, so you'll have to copy any draft release text over to the actual release. Has that been your release practice in the past?
Fixes #5929.