Get correct version of IE11 crypto#274
Merged
broofa merged 1 commit intouuidjs:masterfrom Apr 25, 2018
Merged
Conversation
broofa
reviewed
Apr 25, 2018
Member
broofa
left a comment
There was a problem hiding this comment.
Please change commit message to "fix: Get correct version of IE11 crypto" (per Conventional Commit spec). Other than that this looks fine.
Member
|
Side note: Can't wait for the day optional chaining is a thing. :-p |
748dbbf to
9c37ff0
Compare
Users on Windows 7 and IE11 sometimes trigger a bind error because the crypto object exists but getRandomValues is undefined. Using openpgpjs/openpgpjs#207 as a reference, I've added a more robust check for the necessary crypto properties in IE 11.
9c37ff0 to
2b3db6b
Compare
Contributor
Author
|
Commit message updated. Re: optional chaining, for sure. Although I wish there was an alternate syntax, I'm starting to get PTSD flashbacks from working in CoffeeScript 😅 |
Contributor
Author
|
Oh, btw we have not had any bind errors from node-uuid on IE 11 since we deployed this fork. I believe it works. |
broofa
approved these changes
Apr 25, 2018
Contributor
Author
|
@broofa Can you note when you release a new version on this message so we can pull the official package back into our dependencies? |
broofa
pushed a commit
that referenced
this pull request
Jun 22, 2018
Users on Windows 7 and IE11 sometimes trigger a bind error because the crypto object exists but getRandomValues is undefined. Using openpgpjs/openpgpjs#207 as a reference, I've added a more robust check for the necessary crypto properties in IE 11.
This was referenced Oct 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users on Windows 7 and IE11 sometimes trigger a bind error because the crypto object exists but getRandomValues is undefined. Using openpgpjs/openpgpjs#207 as a reference, I've added a more robust check for the necessary crypto properties in IE 11.
We deployed our branch into production yesterday. I'll report back in a week to let everyone know if this fixed the issue or not, and if so we can potentially merge?