Conversation
Closed
Member
|
Sure, looks good. Should be in v0.5.1 |
robwierzbowski
added a commit
to stitchfix/node-uuid
that referenced
this pull request
Apr 16, 2018
Users on Windows 7 and IE11 sometimes trigger a bind error because the crypto object exists but getRandomValues is undefined. Using openpgpjs/openpgpjs#207 as a reference, I've added a more robust check for the necessary crypto properties in IE 11.
robwierzbowski
added a commit
to stitchfix/node-uuid
that referenced
this pull request
Apr 16, 2018
Users on Windows 7 and IE11 sometimes trigger a bind error because the crypto object exists but getRandomValues is undefined. Using openpgpjs/openpgpjs#207 as a reference, I've added a more robust check for the necessary crypto properties in IE 11.
robwierzbowski
added a commit
to stitchfix/node-uuid
that referenced
this pull request
Apr 25, 2018
Users on Windows 7 and IE11 sometimes trigger a bind error because the crypto object exists but getRandomValues is undefined. Using openpgpjs/openpgpjs#207 as a reference, I've added a more robust check for the necessary crypto properties in IE 11.
robwierzbowski
added a commit
to stitchfix/node-uuid
that referenced
this pull request
Apr 25, 2018
Users on Windows 7 and IE11 sometimes trigger a bind error because the crypto object exists but getRandomValues is undefined. Using openpgpjs/openpgpjs#207 as a reference, I've added a more robust check for the necessary crypto properties in IE 11.
broofa
pushed a commit
to uuidjs/uuid
that referenced
this pull request
Apr 25, 2018
Users on Windows 7 and IE11 sometimes trigger a bind error because the crypto object exists but getRandomValues is undefined. Using openpgpjs/openpgpjs#207 as a reference, I've added a more robust check for the necessary crypto properties in IE 11.
broofa
pushed a commit
to uuidjs/uuid
that referenced
this pull request
Jun 22, 2018
Users on Windows 7 and IE11 sometimes trigger a bind error because the crypto object exists but getRandomValues is undefined. Using openpgpjs/openpgpjs#207 as a reference, I've added a more robust check for the necessary crypto properties in IE 11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@toberndo this fixes #203
If it's ok, we can include it in the v0.5.1 release.