Fix Schematron paths in profile resolver XML files#1945
Merged
aj-stein-nist merged 1 commit intousnistgov:developfrom Oct 5, 2023
Merged
Fix Schematron paths in profile resolver XML files#1945aj-stein-nist merged 1 commit intousnistgov:developfrom
aj-stein-nist merged 1 commit intousnistgov:developfrom
Conversation
Contributor
Author
|
@aj-stein-nist : I know there is a lot going on now for your team, and this pull request is not at all urgent. I just wanted to push the change while it was on my mind. The PR can sit. |
Contributor
Thanks, @galtm. I will try and make a quick review before COB tomorrow if possible. If others in the team have bandwidth, they can feel free to review as well. I assigned it to the whole team to take a look. |
aj-stein-nist
approved these changes
Oct 5, 2023
Contributor
aj-stein-nist
left a comment
There was a problem hiding this comment.
Checked the paths and looks good to me. Thanks again for your contributions, @galtm.
galtm
added a commit
to galtm/OSCAL
that referenced
this pull request
Feb 23, 2024
- 2nd argument of resolve-uri makes the path relative to the original XSpec file instead of the compiled one, whose location can vary depending on how the test is run - Remove one ../ from URI to resolve (similar to usnistgov#1945) because of directory reorg
iMichaela
pushed a commit
that referenced
this pull request
Feb 26, 2024
- 2nd argument of resolve-uri makes the path relative to the original XSpec file instead of the compiled one, whose location can vary depending on how the test is run - Remove one ../ from URI to resolve (similar to #1945) because of directory reorg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Notes
While working on #1944, I found that some XML files refer to Schematron schemas using relative paths that need one less
../now that the profile resolver code has moved. This change can be decoupled from #1944, so I'm making it a separate pull request instead of tacking it onto #1944.I checked this change by opening the 3 files in Oxygen and validating them. Before this change, I got error messages about Schematron files not being found, such as
...\OSCAL\specifications\profile-resolution\example-checkup.sch (The system cannot find the path specified). After this change, I no longer got those errors.All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features:
Have you written new tests for your core changes, as applicable?This does fix existing tests.Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.