Profiler error handling#1944
Merged
aj-stein-nist merged 2 commits intousnistgov:feature-profile-error-handlingfrom Sep 29, 2023
Merged
Profiler error handling#1944aj-stein-nist merged 2 commits intousnistgov:feature-profile-error-handlingfrom
aj-stein-nist merged 2 commits intousnistgov:feature-profile-error-handlingfrom
Conversation
The profile resolver code is less deep than before, so a relative path from there to the specification uses one less `../` piece.
6 tasks
aj-stein-nist
approved these changes
Sep 29, 2023
Contributor
aj-stein-nist
left a comment
There was a problem hiding this comment.
Thanks for this @galtm, I tested locally and it looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another attempt at rebasing the previously reviewed PR #1549. The base is
developand all the files I changed are undersrc/utils/resolver-pipeline. There are 2 commits:I ran all the profile resolver XSpec tests in Oxygen and there are no failures.
@aj-stein-nist : Is this pull request a reasonable replacement for #1549, or does #1943 have some advantage?
Committer Notes
{Please provide a brief description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please include [WIP] at the beginning of the title or mark the PR as DRAFT.}
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features:
Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.