Skip to content

243 test dep group doesnt seem to install automatically#267

Merged
nathanjmcdougall merged 6 commits into
mainfrom
243-test-dep-group-doesnt-seem-to-install-automatically
Feb 6, 2025
Merged

243 test dep group doesnt seem to install automatically#267
nathanjmcdougall merged 6 commits into
mainfrom
243-test-dep-group-doesnt-seem-to-install-automatically

Conversation

@nathanjmcdougall

Copy link
Copy Markdown
Collaborator

No description provided.

@nathanjmcdougall nathanjmcdougall linked an issue Feb 6, 2025 that may be closed by this pull request
@nathanjmcdougall

Copy link
Copy Markdown
Collaborator Author

Also before merging (and related to the failing tests): I don't like that we add "dev" explicitly to the tool.uv section when it's already installed by default. I think it would be better to only add "dev" if:

  • The section doesn't already exist
  • Another section is being added

@codspeed-hq

codspeed-hq Bot commented Feb 6, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #267 will not alter performance

Comparing 243-test-dep-group-doesnt-seem-to-install-automatically (7cb0123) with main (941aaa6)

Summary

✅ 1 untouched benchmarks

@nathanjmcdougall nathanjmcdougall merged commit 9b1ee0e into main Feb 6, 2025
@nathanjmcdougall nathanjmcdougall deleted the 243-test-dep-group-doesnt-seem-to-install-automatically branch February 6, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test dep group doesn't seem to install automatically

1 participant