Add UsethisConfig.copy method to simplify set#1825
Merged
Conversation
- Add `copy()` method using `dataclasses.replace` to create a shallow copy - Add private `_restore()` method to restore state from a copy - Simplify `set()` to use `copy`/`_restore` instead of attribute-by-attribute save/restore, removing 20+ lines of repetitive code - Remove now-unnecessary PLR0915 noqa suppression - Add tests for the new `copy` method Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/8e4db7cc-5876-49e5-9601-e64a0a24f831 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/8e4db7cc-5876-49e5-9601-e64a0a24f831 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add UsethisConfig.copy method to simplify UsethisConfig.set
Add Apr 6, 2026
UsethisConfig.copy method to simplify set
nathanjmcdougall
approved these changes
Apr 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UsethisConfig.setperformed attribute-by-attribute save/restore across all 11 config fields, making it verbose and fragile when fields are added.copy()method: Returns a shallow copy viadataclasses.replace, replacing 11 individualold_* = self.*assignments withold = self.copy()_restore()method: Restores all fields from a snapshot viadataclasses.fields, replacing 11 individualself.* = old_*assignments withself._restore(old)PLR0915suppression removed: Statement count dropped enough to remove the noqa commentTestCopycovers identity, value preservation across all fields, and independence from original