packages/bruno-requests/src/grpc/grpc-client.js (2)

531-543: User-agent extraction logic is correct but duplicated.

The case-insensitive extraction and channel option assignment work as intended. However, this same logic appears again in loadMethodsFromReflection (lines 631-637). Consider extracting to a helper function to avoid duplication.

Also, note that the spread order { 'grpc.primary_user_agent': userAgentValue, ...channelOptions } means an explicit grpc.primary_user_agent in channelOptions will override the header-derived value. If you intend for the header to always take precedence, reverse the spread order.

♻️ Suggested helper extraction

+/**
+ * Extracts user-agent from headers (case-insensitive) and merges into channel options
+ * `@param` {Object} headers - Request headers
+ * `@param` {Object} channelOptions - Existing channel options
+ * `@returns` {Object} Merged channel options with grpc.primary_user_agent if present
+ */
+const mergeUserAgentIntoChannelOptions = (headers, channelOptions = {}) => {
+  const userAgentKey = Object.keys(headers || {}).find(
+    (key) => key.toLowerCase() === 'user-agent'
+  );
+  const userAgentValue = userAgentKey ? headers[userAgentKey] : null;
+  return userAgentValue
+    ? { 'grpc.primary_user_agent': userAgentValue, ...channelOptions }
+    : channelOptions;
+};

Then use it in both locations:

const mergedChannelOptions = mergeUserAgentIntoChannelOptions(request.headers, channelOptions);

---

626-637: Inconsistent default for channelOptions parameter.

In startConnection, channelOptions defaults to {} (line 478), but here in loadMethodsFromReflection there's no default value. If channelOptions is undefined, the spread will work but the inconsistency is confusing.

♻️ Add default value for consistency

     verifyOptions,
     sendEvent,
-    channelOptions
+    channelOptions = {}
   }) {

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Learnt from: bijin-bruno
Repo: usebruno/bruno PR: 6263
File: packages/bruno-requests/src/auth/oauth2-helper.ts:249-249
Timestamp: 2025-12-02T07:24:50.311Z
Learning: In OAuth2 Basic Auth headers for Bruno, clientSecret is optional and can be omitted. When constructing the Authorization header in `packages/bruno-requests/src/auth/oauth2-helper.ts`, use `clientSecret || ''` instead of `clientSecret!` to properly handle cases where only clientId is provided, per community requests.

Learnt from: naman-bruno
Repo: usebruno/bruno PR: 6407
File: packages/bruno-app/src/components/Environments/ConfirmCloseEnvironment/index.js:5-41
Timestamp: 2025-12-17T21:41:24.730Z
Learning: Do not suggest PropTypes validation for React components in the Bruno codebase. The project does not use PropTypes, so reviews should avoid proposing PropTypes and rely on the existing typing/validation approach (e.g., TypeScript or alternative runtime checks) if applicable. This guideline applies broadly to all JavaScript/JSX components in the repo.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

packages/bruno-requests/src/grpc/grpc-client.spec.js (1)

188-204: Key ordering assertion is implementation-sensitive.

This test relies on Object.keys() returning keys in insertion order. While ES2015+ guarantees this for string keys, asserting on key position couples the test to how the production code constructs the object. If someone refactors the merging logic (e.g., using Object.assign() differently), this test could break even if the functional behavior is correct.

Consider whether this ordering is a requirement worth testing, or if testing presence/values is sufficient.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Learnt from: CR
Repo: usebruno/bruno PR: 0
File: CODING_STANDARDS.md:0-0
Timestamp: 2025-12-05T20:31:33.005Z
Learning: Applies to **/*.test.{js,jsx,ts,tsx} : Add tests for any new functionality or meaningful changes. If code is added, removed, or significantly modified, corresponding tests should be updated or created

Learnt from: naman-bruno
Repo: usebruno/bruno PR: 6407
File: packages/bruno-app/src/components/Environments/ConfirmCloseEnvironment/index.js:5-41
Timestamp: 2025-12-17T21:41:24.730Z
Learning: Do not suggest PropTypes validation for React components in the Bruno codebase. The project does not use PropTypes, so reviews should avoid proposing PropTypes and rely on the existing typing/validation approach (e.g., TypeScript or alternative runtime checks) if applicable. This guideline applies broadly to all JavaScript/JSX components in the repo.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}