You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like the gRPC client always override the useragent passed in the metdata headers.
Would you accept such a change, where we only set the useragent if there is not one that is passed through the headers already? Happy to add tests if that looks good to you
If you look at the code where this.userAgent is set, you can see that it uses channel arguments to determine that value. Our expectation is that any single client will have the same user agent for all requests it makes (or at least, all requests it makes to a single service), so you should set the value once for the whole client using those channel arguments, instead of setting it for every request.
Our position is that even when used as a proxy, the library should send its own user agent because it is the actual source of the request. So, we are not going to add support for overriding the user agent in this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the gRPC client always override the useragent passed in the metdata headers.
Would you accept such a change, where we only set the useragent if there is not one that is passed through the headers already? Happy to add tests if that looks good to you