Skip to content

fix: rename requests double notifications#6677

Merged
sid-bruno merged 3 commits intousebruno:mainfrom
shubh-bruno:fix/rename-requests-notification
Jan 14, 2026
Merged

fix: rename requests double notifications#6677
sid-bruno merged 3 commits intousebruno:mainfrom
shubh-bruno:fix/rename-requests-notification

Conversation

@shubh-bruno
Copy link
Collaborator

@shubh-bruno shubh-bruno commented Jan 5, 2026

Description

Jira

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

  • Improvements
    • Workspace deletion now displays a success confirmation message when a workspace is successfully removed
    • Workspace renaming operations now show a success confirmation message upon successful completion
    • Refined error handling and user feedback messaging for file operation workflows

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 5, 2026

Walkthrough

This change adds success toast notifications to workspace deletion and renaming operations, and removes error toast feedback from a file rename action. These modifications enhance user feedback on completion of workspace management operations.

Changes

Cohort / File(s) Summary
Workspace Management Success Feedback
packages/bruno-app/src/components/ManageWorkspace/DeleteWorkspace/index.js, packages/bruno-app/src/components/ManageWorkspace/RenameWorkspace/index.js
Added toast.success() notifications after successful workspace deletion and rename operations to provide explicit user feedback on completion.
Collection Item Rename Error Handling
packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js
Removed error toast from renameItem catch block; error is now logged and rethrown without user-facing notification.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

size/M

Suggested reviewers

  • lohit-bruno
  • bijin-bruno
  • helloanoop

Poem

✨ A toast for success, when workspaces part,
And toasts when they're renamed with care,
User feedback, the little art,
That shows the system's aware! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main objective of the PR: fixing duplicate notifications when renaming requests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8300abe and f00a646.

📒 Files selected for processing (3)
  • packages/bruno-app/src/components/ManageWorkspace/DeleteWorkspace/index.js
  • packages/bruno-app/src/components/ManageWorkspace/RenameWorkspace/index.js
  • packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js
💤 Files with no reviewable changes (1)
  • packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (CODING_STANDARDS.md)

**/*.{js,jsx,ts,tsx}: Use 2 spaces for indentation. No tabs, just spaces
Stick to single quotes for strings. For JSX/TSX attributes, use double quotes (e.g., )
Always add semicolons at the end of statements
No trailing commas
Always use parentheses around parameters in arrow functions, even for single params
For multiline constructs, put opening braces on the same line, and ensure consistency. Minimum 2 elements for multiline
No newlines inside function parentheses
Space before and after the arrow in arrow functions. () => {} is good
No space between function name and parentheses. func() not func ()
Semicolons go at the end of the line, not on a new line
Names for functions need to be concise and descriptive
Add in JSDoc comments to add more details to the abstractions if needed
Add in meaningful comments instead of obvious ones where complex code flow is explained properly

Files:

  • packages/bruno-app/src/components/ManageWorkspace/DeleteWorkspace/index.js
  • packages/bruno-app/src/components/ManageWorkspace/RenameWorkspace/index.js
🧠 Learnings (1)
📚 Learning: 2025-12-17T21:41:24.730Z
Learnt from: naman-bruno
Repo: usebruno/bruno PR: 6407
File: packages/bruno-app/src/components/Environments/ConfirmCloseEnvironment/index.js:5-41
Timestamp: 2025-12-17T21:41:24.730Z
Learning: Do not suggest PropTypes validation for React components in the Bruno codebase. The project does not use PropTypes, so reviews should avoid proposing PropTypes and rely on the existing typing/validation approach (e.g., TypeScript or alternative runtime checks) if applicable. This guideline applies broadly to all JavaScript/JSX components in the repo.

Applied to files:

  • packages/bruno-app/src/components/ManageWorkspace/DeleteWorkspace/index.js
  • packages/bruno-app/src/components/ManageWorkspace/RenameWorkspace/index.js
🔇 Additional comments (2)
packages/bruno-app/src/components/ManageWorkspace/RenameWorkspace/index.js (1)

37-44: LGTM - Success feedback improves UX.

The success toast provides clear user feedback after workspace rename. The pattern of calling onClose() before showing the toast ensures the modal closes first, which is consistent with the DeleteWorkspace implementation.

packages/bruno-app/src/components/ManageWorkspace/DeleteWorkspace/index.js (1)

13-25: LGTM - Consistent success feedback pattern.

The success toast follows the same pattern as RenameWorkspace, providing clear user feedback after workspace deletion. Error handling is properly maintained with the isDeleting state reset only in the catch block.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sid-bruno sid-bruno merged commit 4c11090 into usebruno:main Jan 14, 2026
8 checks passed
FraCata00 pushed a commit to FraCata00/bruno that referenced this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants