fix: duplicate message on workspace rename and close by naman-bruno · Pull Request #6457 · usebruno/bruno

naman-bruno · 2025-12-18T13:13:30Z

Description

Contribution Checklist:

I've used AI significantly to create this pull request
The pull request only addresses one issue or adds one feature.
The pull request does not introduce any breaking changes
I have added screenshots or gifs to help explain the change if applicable.
I have read the contribution guidelines.
Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

Bug Fixes
- Removed success notifications previously displayed when renaming or closing workspaces.
Style
- Updated workspace accent color in dark theme for visual refinement.
- Adjusted collection icon wrapper styling for improved consistency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-18T13:13:43Z

Walkthrough

Three isolated styling and notification updates: the dark theme's workspace accent color shifts from gold to bronze, success toasts are removed from workspace action handlers, and explicit color styling is stripped from the collection icon wrapper element.

Changes

Cohort / File(s)	Summary
Theme & Styling Updates `packages/bruno-app/src/themes/dark.js`, `packages/bruno-app/src/components/WorkspaceHome/WorkspaceOverview/CollectionsList/StyledWrapper.js`	Updated dark theme workspace accent color from `#F59E0B` to `#D9A342`; removed explicit color styling from `.collection-icon-wrapper`
Toast Notification Removal `packages/bruno-app/src/providers/ReduxStore/slices/workspaces/actions.js`	Removed success toasts from `renameWorkspaceAction` and `closeWorkspaceAction`

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Straightforward removals and color value updates with no complex logic changes
Verify the new accent color (#D9A342) aligns with design intent across the theme
Confirm toast removal doesn't impact user feedback expectations for workspace operations

Possibly related PRs

add: manage workspace #6424: Directly related — removes the same workspace action success toasts that may interact with dependent features

Suggested labels

size/S

Suggested reviewers

helloanoop
lohit-bruno
bijin-bruno

Poem

🎨 Gold to bronze, the workspace glows,
Toasts fade softly as the action flows,
Colors dance without their chains—
A subtle shift, yet fresh remains! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing duplicate success toast messages from workspace rename and close operations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1cc117c and b35887c.

📒 Files selected for processing (3)

packages/bruno-app/src/components/WorkspaceHome/WorkspaceOverview/CollectionsList/StyledWrapper.js (0 hunks)
packages/bruno-app/src/providers/ReduxStore/slices/workspaces/actions.js (0 hunks)
packages/bruno-app/src/themes/dark.js (1 hunks)

💤 Files with no reviewable changes (2)

packages/bruno-app/src/providers/ReduxStore/slices/workspaces/actions.js
packages/bruno-app/src/components/WorkspaceHome/WorkspaceOverview/CollectionsList/StyledWrapper.js

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (CODING_STANDARDS.md)

**/*.{js,jsx,ts,tsx}: Use 2 spaces for indentation. No tabs, just spaces
Stick to single quotes for strings. For JSX/TSX attributes, use double quotes (e.g., )
Always add semicolons at the end of statements
No trailing commas
Always use parentheses around parameters in arrow functions, even for single params
For multiline constructs, put opening braces on the same line, and ensure consistency. Minimum 2 elements for multiline
No newlines inside function parentheses
Space before and after the arrow in arrow functions. () => {} is good
No space between function name and parentheses. func() not func ()
Semicolons go at the end of the line, not on a new line
Names for functions need to be concise and descriptive
Add in JSDoc comments to add more details to the abstractions if needed
Add in meaningful comments instead of obvious ones where complex code flow is explained properly

Files:

packages/bruno-app/src/themes/dark.js

🧠 Learnings (2)

📚 Learning: 2025-12-05T20:31:33.005Z

Learnt from: CR
Repo: usebruno/bruno PR: 0
File: CODING_STANDARDS.md:0-0
Timestamp: 2025-12-05T20:31:33.005Z
Learning: Applies to **/*.{jsx,tsx} : Use styled component's theme prop to manage CSS colors and not CSS variables when in the context of a styled component or any React component using the styled component

Applied to files:

packages/bruno-app/src/themes/dark.js

📚 Learning: 2025-12-17T21:41:24.730Z

Learnt from: naman-bruno
Repo: usebruno/bruno PR: 6407
File: packages/bruno-app/src/components/Environments/ConfirmCloseEnvironment/index.js:5-41
Timestamp: 2025-12-17T21:41:24.730Z
Learning: Do not suggest PropTypes validation for React components in the Bruno codebase. The project does not use PropTypes, so reviews should avoid proposing PropTypes and rely on the existing typing/validation approach (e.g., TypeScript or alternative runtime checks) if applicable. This guideline applies broadly to all JavaScript/JSX components in the repo.

Applied to files:

packages/bruno-app/src/themes/dark.js

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

GitHub Check: Playwright E2E Tests
GitHub Check: Unit Tests
GitHub Check: CLI Tests
GitHub Check: SSL Tests - macOS
GitHub Check: SSL Tests - Linux
GitHub Check: SSL Tests - Windows

coderabbitai · 2025-12-18T13:16:01Z

packages/bruno-app/src/themes/dark.js


  workspace: {
-    accent: '#F59E0B',
+    accent: '#D9A342',


⚠️ Potential issue | 🟡 Minor

Standardize hex color casing to lowercase.

The new accent color uses uppercase #D9A342, but the file consistently uses lowercase hex colors elsewhere (e.g., lines 2, 9, 150). Update to #d9a342 for consistency.

🔎 Apply this diff:

workspace: { - accent: '#D9A342', + accent: '#d9a342', border: '#444',

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

accent: '#D9A342',

accent: '#d9a342',

🤖 Prompt for AI Agents

In packages/bruno-app/src/themes/dark.js around line 163, the accent color hex is uppercase "#D9A342" while the file uses lowercase hex values elsewhere; update the value to the lowercase string "#d9a342" so it matches the project's hex casing convention (replace the existing accent value with the lowercase hex).

fix: duplicate message on workspace rename and close

b35887c

naman-bruno requested review from bijin-bruno, helloanoop and lohit-bruno as code owners December 18, 2025 13:13

pull-request-size bot added the size/XS label Dec 18, 2025

coderabbitai bot reviewed Dec 18, 2025

View reviewed changes

bijin-bruno approved these changes Dec 18, 2025

View reviewed changes

bijin-bruno merged commit 6ab8fcb into usebruno:main Dec 18, 2025
8 checks passed

coderabbitai bot mentioned this pull request Dec 18, 2025

add: workspace tabs #6456

Merged

6 tasks

This was referenced Dec 30, 2025

Bugfix/workspace name case mismatch #6560

Merged

Persist workspace state across app restarts #6573

Open

fix: rename requests double notifications #6677

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: duplicate message on workspace rename and close#6457

fix: duplicate message on workspace rename and close#6457
bijin-bruno merged 1 commit intousebruno:mainfrom
naman-bruno:bugfix/duplicate-message

naman-bruno commented Dec 18, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Dec 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

naman-bruno commented Dec 18, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contribution Checklist:

Publishing to New Package Managers

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

naman-bruno commented Dec 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 18, 2025 •

edited

Loading