feat(gitbranch): Add git url param to gitbranch plugin#2850
Merged
olblak merged 12 commits intoupdatecli:mainfrom Oct 29, 2024
Merged
feat(gitbranch): Add git url param to gitbranch plugin#2850olblak merged 12 commits intoupdatecli:mainfrom
olblak merged 12 commits intoupdatecli:mainfrom
Conversation
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Member
Author
|
I now realize this plugin is missing a lot of tests... |
4 tasks
* Remove wrong validation as specific validation must be done on target * Add sourcebranch parameter to specify what existing branch must be used to create the new one Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to #2848
This pull request allows using the gitbranch plugin with a URL without having to specify a scmid
Using the scmid comes with the requirement that we need to know what branch the git repository use (master vs main) as Updatecli run git checkout operation before handling a resource, but in the context of the gitbranch all we need is running git clone to retrieve the branch locally.
The gitbranch plugin can now be used in three different ways
#1964
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement
I am considering deprecating the parameter path in favor of directory to align with scm naming