feat(gittag): Add git url param to gittag plugin#2848
Merged
olblak merged 8 commits intoupdatecli:mainfrom Oct 25, 2024
Merged
Conversation
Signed-off-by: Olblak <me@olblak.com>
4 tasks
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
* Allow to use gittag target with sourceinput disable * Fix password for gittag target using URL * Don't apply versionfilter on an empty tag list * Ensure we provide a git tag name to create Signed-off-by: Olblak <me@olblak.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request allows using the
gittagplugin with a URL without having to specify a scmidUsing the scmid comes with the requirement that we need to know what branch the git repository use (master vs main) as Updatecli run
git checkoutoperation before handling a resource, but in the context of the gittag all we need is runninggit cloneto retrieve the tag locally.The gittag plugin can now be used in three different ways
scmidto clone the repositorypathparameter to analyze an already cloned git repositoryurlparameter to clone and then analyze the repository, which is more convenient for autodiscovery plugin like feat: add GitHub action autodiscovery plugin #1964Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement
I am considering deprecating the parameter
pathin favor ofdirectoryto align with scm naming