Merged
Conversation
WalkthroughThis update increments the version of the Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project version from v1.6.0 to v1.6.1 and adjusts the CHANGELOG accordingly to reflect new bug fixes.
- Bump package version in Cargo.toml
- Add new bug fixes section in CHANGELOG.md with updated changelog entries
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Cargo.toml | Version bump to release v1.6.1 |
| CHANGELOG.md | Added changelog entries for v1.6.1 with updated bug fix descriptions |
Files not reviewed (1)
- npm/package.json: Language not supported
Comments suppressed due to low confidence (1)
CHANGELOG.md:24
- [nitpick] The removal of the 'fix:' prefix for the npm-postinstall dependency entry creates an inconsistency with the expected naming format in the bug fixes section. Consider reintroducing the prefix or revising the other entries for consistency.
add `napi-postinstall` dep for workaround `npm`'s bug ([#66](https://github.com/unrs/unrs-resolver/pull/66))
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
=======================================
Coverage 93.20% 93.20%
=======================================
Files 13 13
Lines 2841 2841
=======================================
Hits 2648 2648
Misses 193 193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 056933e in 1 minute and 17 seconds. Click for details.
- Reviewed
64lines of code in4files - Skipped
0files when reviewing. - Skipped posting
11draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Cargo.toml:7
- Draft comment:
Version bump updated to 1.6.1; please ensure it is consistently reflected in all package metadata. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to ensure consistency in versioning across package metadata. It falls under the category of asking the author to double-check things, which is against the rules. Therefore, this comment should be removed.
2. Cargo.toml:90
- Draft comment:
Check the default features, especially fs_cache and yarn_pnp, to ensure they're intended for all users. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. npm/package.json:3
- Draft comment:
Version updated to 1.6.1; verify consistency with Cargo.toml and overall release. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to verify consistency withCargo.tomland the overall release, which falls under asking the author to double-check things. This violates the rules as it is not a specific code suggestion or request for a test.
4. npm/package.json:47
- Draft comment:
Postinstall script uses 'napi-postinstall unrs-resolver check'. Confirm that 'check' parameter is correct for your intended behavior. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. Cargo.toml:7
- Draft comment:
Version bump to 1.6.1 is correctly applied and consistent. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
6. Cargo.lock:1192
- Draft comment:
Cargo.lock reflects the updated package version 1.6.1. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
7. npm/package.json:3
- Draft comment:
npm package version updated to 1.6.1, ensuring consistency with Rust crate. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
8. CHANGELOG.md:13
- Draft comment:
Typo: 'linux' should be capitalized to 'Linux' since it's a proper noun referring to the operating system. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While technically correct that 'Linux' is typically capitalized as a proper noun, this is a changelog entry and the capitalization doesn't affect functionality. The comment is purely stylistic and not critical. The rules state not to make purely informative comments or comments that are obvious/unimportant. This seems to fall into that category. The capitalization of Linux is a widely accepted convention and could be seen as a legitimate documentation issue since this is user-facing text in the changelog. While proper capitalization is good practice, this minor stylistic issue doesn't rise to the level of requiring a comment. The rules specifically say not to make purely informative comments or comments about obvious/unimportant issues. This comment should be removed as it addresses a minor stylistic issue that doesn't materially affect the project or require immediate action.
9. CHANGELOG.md:42
- Draft comment:
Typographical error: 'pacakge.json' should be corrected to 'package.json'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
10. CHANGELOG.md:421
- Draft comment:
Typographical error: The markdown formatting for the NAPI label appears incorrect. It currently reads '(napi' but should likely be '(napi)' to maintain proper emphasis formatting. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
11. npm/package.json:43
- Draft comment:
Typographical Error: The target 'wasm32-wasip1-threads' may contain a typo ('wasip1'). Please verify if it should be corrected to 'wasm32-wasi-threads'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_fk3NtjfNjBSk8G2H
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
CodSpeed Performance ReportMerging #70 will not alter performanceComparing Summary
|
This was referenced Apr 24, 2025
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Release v1.6.1 with a bug fix disabling
mimallocon Linuxaarch64.1.6.1inCargo.toml,Cargo.lock, andnpm/package.json.mimallocon Linux withaarch64as noted inCHANGELOG.md.This description was created by
for 056933e. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit
Documentation
Chores