Conversation
Yoshito is making this change on behalf of @datalogics-robb. IBM's XL compiler can only support c++11 when the 'clang front end' is used. This change modifies the configure step to use xlclang and xlclang++ Change readme.html reference to xlC to refer to xlclang++ instead.
…ic DST setting is OFF to ICU 68. cherry-picked from commit a1a1faf
This change backports the GHA script to the maint/maint-68 branch. Related ICU tickets: https://unicode-org.atlassian.net/browse/ICU-21434 https://unicode-org.atlassian.net/browse/ICU-21450 Cherry-picked from: 8078ae4 Cherry-picked from: 38125f3 Cherry-picked from: e5a3f2b Cherry-picked from: c7ea02f
…by default in ICU 69
The two libraries are in the wrong order causing the static build to fail (at least on Windows). There are three more Makefile's (in tests and samples) with the same issue. However, those have no apparent effect on the build process (it completes successfully), so I did not fix them. Remove static and version suffixes on MinGW platform Static libraries should not use numeric suffixes on the MinGW/Windows platform. Additionally, the static "s" suffix should also be dropped.
Ah, I think this might have caused git/GitHub to get confused, as now this PR shows 15 commits to be merged into I think the commit for this PR might need to be rebased onto |
|
Thank you very much for creating this PR, signing the CLA, and also for filing a ticket! :) FWIW, the changes in the commit here: 956683a seem mostly fine to me. However, I'm not super familiar with the MinGW build environment. For the static library changes, that PR removes Would you be able to take a look at the other PR? Thank you! |
@jefgen #1733 does not remove STATIC_PREFIX_WHEN_USED, because it was not there at all. I added STATIC_PREFIX_WHEN_USED and STATIC_PREFIX to mh-mingw, but #1733 is based on commit not incorporating mine. #1733 achieves the same result by removing STATIC_PREFIX from LIBSICU. My personal preference would be setting STATIC_PREFIX to an empty string, but either approach fixes mh-mingw as far as the static build is concerned. |
|
@pchemguy you do need to rebase this on |
|
This PR can be closed in favor of #1735 |
|
Closed in favor of #1735 |
The two libraries are in the wrong order causing the static build to fail (at least on Windows). There are three more Makefile's (in tests and samples) with the same issue. However, those have no apparent effect on the build process (it completes successfully), so I did not fix them.
Static libraries should not use numeric suffixes on the MinGW/Windows platform. Additionally, the static "s" suffix should also be dropped.
https://unicode-org.atlassian.net/browse/ICU-21627