ICU-21356 Fix memory handling in MemoryPool::operator=()#1437
Merged
hugovdm merged 1 commit intounicode-org:masterfrom Oct 29, 2020
Merged
ICU-21356 Fix memory handling in MemoryPool::operator=()#1437hugovdm merged 1 commit intounicode-org:masterfrom
hugovdm merged 1 commit intounicode-org:masterfrom
Conversation
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
hugovdm
commented
Oct 28, 2020
roubert
previously requested changes
Oct 28, 2020
Member
roubert
left a comment
There was a problem hiding this comment.
I think this change makes sense, please just clean up the commits and make sure that all tests pass.
Contributor
Author
|
I'm doing the usual leaving of squashing until after a reviewer is happy: an extra round trip, but makes review comments and reviewing diffs more streamlined. |
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
sffc
approved these changes
Oct 29, 2020
roubert: "The changes to cmemory.h look good to me now", and sffc has now also approved.
Contributor
Author
|
appveyor timed out: "Build execution time has reached the maximum allowed time for your plan (60 minutes)." Merging! |
sffc
pushed a commit
that referenced
this pull request
Dec 2, 2020
sffc
pushed a commit
that referenced
this pull request
Dec 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Question to reviewer: indirectly testing this via MeasureUnitImpl: sufficient? Or should I produce a unit test specifically for a MemoryPool instance?
The old array can't simply be deallocated, their pointers still need to be deallcoated too.
Using swap() ensures that the destructor can take care of it when
otheris deallocated.Checklist