ICU-21410 fix int32_t overflow in listFormat#1479
Merged
FrankYFTang merged 1 commit intounicode-org:masterfrom Nov 24, 2020
Merged
ICU-21410 fix int32_t overflow in listFormat#1479FrankYFTang merged 1 commit intounicode-org:masterfrom
FrankYFTang merged 1 commit intounicode-org:masterfrom
Conversation
sffc
requested changes
Nov 20, 2020
| if (U_FAILURE(status)) { | ||
| return count; | ||
| } | ||
| U_ASSERT(position >= 0); |
Member
There was a problem hiding this comment.
Can you put all these U_ASSERTs inside prepareForInsert?
| char16_t *oldChars = getCharPtr(); | ||
| Field *oldFields = getFieldPtr(); | ||
| if (fLength + count > oldCapacity) { | ||
| if ((fLength + count) > std::numeric_limits<int32_t>::max() / 2) { |
Member
There was a problem hiding this comment.
You can use INT32_MAX instead in ICU4C
Contributor
Author
|
PTAL |
sffc
previously approved these changes
Nov 23, 2020
Member
|
LGTM please squash |
f52edc2 to
417b0a7
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Contributor
Author
|
squashed , please approve again |
sffc
approved these changes
Nov 23, 2020
sffc
pushed a commit
that referenced
this pull request
Dec 2, 2020
sffc
pushed a commit
that referenced
this pull request
Dec 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist