ICU-21560 mingw: Remove version numbers from link flags#1668
Merged
jefgen merged 1 commit intounicode-org:mainfrom Mar 31, 2021
Merged
ICU-21560 mingw: Remove version numbers from link flags#1668jefgen merged 1 commit intounicode-org:mainfrom
jefgen merged 1 commit intounicode-org:mainfrom
Conversation
Member
|
Thank you for filing an issue and creating a PR for this! |
jefgen
approved these changes
Mar 31, 2021
lazka
added a commit
to lazka/MINGW-packages
that referenced
this pull request
Aug 28, 2021
The dropped patches have been fixed upstream: unicode-org/icu#1505 unicode-org/icu#1668
lazka
added a commit
to lazka/MINGW-packages
that referenced
this pull request
Aug 28, 2021
The dropped patches have been fixed upstream: unicode-org/icu#1505 unicode-org/icu#1668
kou
pushed a commit
to kou/MINGW-packages
that referenced
this pull request
Oct 18, 2021
The dropped patches have been fixed upstream: unicode-org/icu#1505 unicode-org/icu#1668
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
On mingw, the import libraries are unversioned (libicudt.dll.a, libicuuc.dll.a, etc.), while the link flags are versioned. Using gcc + bfd/gold, this isn't a problem, since the DLL files are versioned, and the linker can link to the DLL directly, albeit not recommended. However, clang + lld prohibits linking to a DLL, so we have to use the import libraries, which means removing the version number from the link flags.