ICU-21435 Remove -Bsymbolic flag for mingw targets#1505
Merged
jefgen merged 1 commit intounicode-org:masterfrom Jan 20, 2021
Merged
ICU-21435 Remove -Bsymbolic flag for mingw targets#1505jefgen merged 1 commit intounicode-org:masterfrom
jefgen merged 1 commit intounicode-org:masterfrom
Conversation
|
|
Member
Right, based on the page here: https://ftp.gnu.org/old-gnu/Manuals/ld-2.9.1/html_node/ld_3.html
So it sounds like this would only really be for ELF platforms, whereas IIRC, the MinGW makefiles for ICU are only for building DLLs. -- So I think this lgtm as well. :) |
lazka
added a commit
to lazka/MINGW-packages
that referenced
this pull request
Aug 28, 2021
The dropped patches have been fixed upstream: unicode-org/icu#1505 unicode-org/icu#1668
lazka
added a commit
to lazka/MINGW-packages
that referenced
this pull request
Aug 28, 2021
The dropped patches have been fixed upstream: unicode-org/icu#1505 unicode-org/icu#1668
kou
pushed a commit
to kou/MINGW-packages
that referenced
this pull request
Oct 18, 2021
The dropped patches have been fixed upstream: unicode-org/icu#1505 unicode-org/icu#1668
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
After doing some research, it seems that the -Bsymbolic flag only makes sense on ELF platforms. The mingw linker driver for lld also doesn't support this flag either, so it should be removed.