Walkthrough

Removed two public static helper methods from FindOptionsUtils that applied FindOptions to a query builder, leaving only the tree-specific applyOptionsToTreeQueryBuilder as public. This eliminates the generic options-driven application paths for standard query builders in this file.

Changes

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Caller
  participant FindOptionsUtils
  participant QueryBuilder

  rect rgb(240,248,255)
  Note over Caller,FindOptionsUtils: Previous flow (removed)
  Caller->>FindOptionsUtils: applyOptionsToQueryBuilder(options)
  FindOptionsUtils->>QueryBuilder: configure(select/relations/where/order/skip/take/locks/cache/...)
  FindOptionsUtils-->>Caller: qb
  end

  rect rgb(245,255,245)
  Note over Caller,FindOptionsUtils: Current flow
  alt Tree queries
    Caller->>FindOptionsUtils: applyOptionsToTreeQueryBuilder(treeOptions)
    FindOptionsUtils->>QueryBuilder: configure(tree-specific)
    FindOptionsUtils-->>Caller: qb
  else Non-tree queries
    Note over Caller,QueryBuilder: Caller handles configuration directly (no generic options helper)
  end
  end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

• applyFindManyOptionsOrConditionsToQueryBuilder is commented out - is that intentional? #11158 — Aligns with removal of applyFindManyOptionsOrConditionsToQueryBuilder/applyOptionsToQueryBuilder from FindOptionsUtils.

Poem

A rabbit taps keys with a quiet cheer,
Two helpers hop out, the path now clear.
The forest of trees still gets its guide,
While plain old fields learn to self-applied.
Fewer trails to wander, code feels light—
Thump-thump, merge it, into the night. 🐇✨

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

typeorm-sql-js-example

npm i https://pkg.pr.new/typeorm/typeorm@11721

commit: 881f370

coverage: 76.433%. remained the same
when pulling 881f370 on DeeprajPandey:style/remove-comments-findOptionsUtils
into 181154a on typeorm:master.