Skip to content

applyFindManyOptionsOrConditionsToQueryBuilder is commented out - is that intentional? #11158

@cgrafton

Description

@cgrafton

Issue description

Attempting to use a function after upgrade that was not removed but commented out

Expected Behavior

https://github.com/typeorm/typeorm/blob/master/src/find-options/FindOptionsUtils.ts#L85 The function here named applyFindManyOptionsOrConditionsToQueryBuilder is commented out. If the function is deprecated I would expect it to be marked as deprecated or deleted.

Actual Behavior

https://github.com/typeorm/typeorm/blob/master/src/find-options/FindOptionsUtils.ts#L85 The function here named applyFindManyOptionsOrConditionsToQueryBuilder is commented out. If that is not intentional, I would expect it to be uncommented out. I can make a PR if that is not intentional.

I did look at the commit history and did not see documentation indicating one way or another:
https://github.com/KazooHR/kazoo-web/pull/13953/files#diff-560f403676ba83a2fe06baf6bb95aac50cd516be15e421ab8c50192e8877803cL48

Steps to reproduce

Visit https://github.com/typeorm/typeorm/blob/master/src/find-options/FindOptionsUtils.ts#L85 and see commented out code

My Environment

Dependency Version
Operating System
Node.js version x.y.zzz
Typescript version x.y.zzz
TypeORM version x.y.zzz

Additional Context

No response

Relevant Database Driver(s)

  • aurora-mysql
  • aurora-postgres
  • better-sqlite3
  • cockroachdb
  • cordova
  • expo
  • mongodb
  • mysql
  • nativescript
  • oracle
  • postgres
  • react-native
  • sap
  • spanner
  • sqlite
  • sqlite-abstract
  • sqljs
  • sqlserver

Are you willing to resolve this issue by submitting a Pull Request?

Yes, I have the time, and I know how to start.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions