Skip to content

Render all async results when there were no sync results#1212

Open
coopy wants to merge 1 commit intotwitter:masterfrom
coopy:fix-async-render
Open

Render all async results when there were no sync results#1212
coopy wants to merge 1 commit intotwitter:masterfrom
coopy:fix-async-render

Conversation

@coopy
Copy link
Copy Markdown

@coopy coopy commented May 5, 2015

Update rendered-count after async results have displayed. This ensures that all async results are rendered.

Update rendered-count _after_ async results have displayed
387290b 
This ensures that all async results are rendered.
@rafaelGuerreiro rafaelGuerreiro mentioned this pull request May 13, 2015
Closed
@rafaelGuerreiro
Copy link
Copy Markdown

rafaelGuerreiro commented May 13, 2015

+1. This closes the issue #1232

@kylecrum kylecrum mentioned this pull request May 13, 2015
Closed
@coopy coopy mentioned this pull request May 13, 2015
Open
@joekur joekur mentioned this pull request May 14, 2015
Closed
This was referenced May 26, 2015
Open
Open
Open
Merged
Yobikap pushed a commit to Yobikap/typeahead.js that referenced this pull request Jun 4, 2015
Limit problem fixed at render async results, see commit twitter#1212 …
6bee0a9 
…in typeahead
@gremo
Copy link
Copy Markdown

gremo commented Jun 16, 2015

This. Should be merged because #1200 doesn't work, at least for me. Spent hours of work trying to figure out what was wrong.

@alexfarrill
Copy link
Copy Markdown

alexfarrill commented Jun 16, 2015

+1 this patch worked for me

@theoephraim
Copy link
Copy Markdown

theoephraim commented Jun 23, 2015

+1
please merge!

@StupidCodeFactory
Copy link
Copy Markdown

StupidCodeFactory commented Jun 26, 2015

+1

@agustaf9 agustaf9 mentioned this pull request Jun 28, 2015
Closed
@siawyoung
Copy link
Copy Markdown

siawyoung commented Jun 30, 2015

+1

@razvanphp
Copy link
Copy Markdown

razvanphp commented Jul 1, 2015

+1
very nasty bug, should be released ASAP.

For me, both PRs work, maybe because my update is called only once..

@Glavin001
Copy link
Copy Markdown

Glavin001 commented Jul 7, 2015

+1 Please merge ASAP!!

@omri
Copy link
Copy Markdown

omri commented Jul 12, 2015

Please merge

@Glavin001
Copy link
Copy Markdown

Glavin001 commented Jul 13, 2015

I am simply using @per-nilsson 's Fork as my project's dependency, until this is merged and resolved. Without it, I cannot use Tyepahead.js at all.

@aj7
Copy link
Copy Markdown

aj7 commented Jul 14, 2015

Please merge asap +1

@thomassnielsen
Copy link
Copy Markdown

thomassnielsen commented Jul 14, 2015

Why isn't this merged yet? O_o

This was referenced Jul 14, 2015
Open
Closed
@anarkia1985
Copy link
Copy Markdown

anarkia1985 commented Jul 15, 2015

You sir are my new favourite person of the month
I've been scratching my head for 1 month wondering what I was doing wrong (without having time to step through the code)

@SebCorbin
Copy link
Copy Markdown

SebCorbin commented Jul 16, 2015

👍 merge please :)

@krazyjakee
Copy link
Copy Markdown

krazyjakee commented Jul 17, 2015

This merge contains fixes for some devastating bugs, why hasn't this been merged and released yet?

@Everlag
Copy link
Copy Markdown

Everlag commented Jul 18, 2015

👍 Just migrated from 0.10.5 and this bug had me very confused. Please merge.

@jarthod
Copy link
Copy Markdown

jarthod commented Jul 18, 2015

Yes, It's sad they don't maintain this properly.
I can't imagine all the time lost for people diagnosing the same bug over and over again 😕

@jlbooker jlbooker mentioned this pull request Oct 5, 2015
Open
@jesperronn jesperronn mentioned this pull request Oct 15, 2015
Closed
@hidakatsuya
Copy link
Copy Markdown

hidakatsuya commented Oct 20, 2015

👍

This was referenced Oct 25, 2015
Open
Open
Open
@rafaellyra
Copy link
Copy Markdown

rafaellyra commented Dec 15, 2015

please, merge it!

@jlbooker jlbooker mentioned this pull request Apr 11, 2016
Open
@peter31
Copy link
Copy Markdown

peter31 commented Apr 25, 2016

As I see anyone who wants to use remote source for dataset in this library comes to this issue :)
I guess it is a good reason for new minor release.

@BallisticPain
Copy link
Copy Markdown

BallisticPain commented May 11, 2016

Wow... this has been an issue for well over a year. I'm using the latest and greatest and we just figured this out. We had no clue why our remote results weren't working!!??!

This claims to be a maintained version of typeahead.js https://github.com/corejavascript/typeahead.js

Hope this helps!

@mdahamiwal
Copy link
Copy Markdown

mdahamiwal commented Jun 23, 2016

  • 1 for merge. Can someone merge it?

@jarthod
Copy link
Copy Markdown

jarthod commented Jun 23, 2016

@mdahamiwal, as you can see in the previous comments, twitter abandoned this repo 1 year ago. The fix is already merged in the community maintained https://github.com/corejavascript/typeahead.js

@jonmaciel
Copy link
Copy Markdown

jonmaciel commented Nov 10, 2016

+1

This was referenced Nov 13, 2016
Closed
Closed
Open
Open
Open
Closed
@pitops
Copy link
Copy Markdown

pitops commented Dec 11, 2016 •
edited
Loading

for rails users add this to your gemfile. Version is 1.0.1 (latest as of this post)

gem 'twitter-typeahead-rails', :git => "git://github.com/pitops/twitter-typeahead-rails.git" , :branch => "bump_version_to_1.0.1"

@panthony panthony mentioned this pull request Feb 23, 2017
Closed
@dgandini
Copy link
Copy Markdown

dgandini commented Jun 5, 2017

The project is abandoned, but the PR worked like a charm.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 18, 2019 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Per Nilsson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@yumoto-akihiro yumoto-akihiro mentioned this pull request Jan 21, 2020
Merged
@urecheatu007 urecheatu007 mentioned this pull request Nov 3, 2020
Closed
@jolelievre jolelievre mentioned this pull request Nov 10, 2021
Open
2 tasks
@coopy
Copy link
Copy Markdown
Author

coopy commented Aug 8, 2022

lol I signed the agreement. I think you can merge this now ⌛️🚀

@Yinci
Copy link
Copy Markdown

Yinci commented Aug 15, 2022

+1 Insane that a PR from over 7 years ago that solves a silent issue is still not merged

@coopy
Copy link
Copy Markdown
Author

coopy commented Jan 6, 2023

a PR from over 7 years ago that solves a silent issue is still not merged

Judging from comment history, this repo is abandoned and replaced by https://github.com/corejavascript/typeahead.js. Hopefully this issue is fixed in that fork!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vgross vgross vgross approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.