Skip to content

Fix bad async suggestions rendering logic#1200

Merged
jharding merged 1 commit intotwitter:integration-0.11.2from
jharding:1185-bad-async-logic
Apr 29, 2015
Merged

Fix bad async suggestions rendering logic#1200
jharding merged 1 commit intotwitter:integration-0.11.2from
jharding:1185-bad-async-logic

Conversation

@jharding
Copy link
Copy Markdown
Contributor

No description provided.

@jharding jharding added this to the 0.11.2 milestone Apr 28, 2015
jharding added a commit that referenced this pull request Apr 29, 2015
Fix bad async suggestions rendering logic
@jharding jharding merged commit 312d481 into twitter:integration-0.11.2 Apr 29, 2015
@mayank-saavn
Copy link
Copy Markdown

This fixes it. Thanks.

@jarthod
Copy link
Copy Markdown

jarthod commented May 26, 2015

#1212 also fixes but with tests ;)

@PacciniBruno
Copy link
Copy Markdown

Same here :'(

@ultimatemanu
Copy link
Copy Markdown

Same for us :) Spent also a few hours to find where the problem was.

@j-kwon
Copy link
Copy Markdown

j-kwon commented Jun 10, 2015

same here, look forward to merging into the master asap.

@gremo
Copy link
Copy Markdown

gremo commented Jun 16, 2015

#1200 works for you guys? Because for me it doesn't. Limit: 5, result set: 5, shown: 0. #1212 fixes the problem at least for me.

@eins78
Copy link
Copy Markdown

eins78 commented Jun 22, 2015

I can confirm that pr #1200 (this) does not fix issue #1232, but pr #1212 does (and, as others have pointed out comes with a test).

@Floby
Copy link
Copy Markdown

Floby commented Jul 6, 2015

Any idea when this is going into master ?

@davis
Copy link
Copy Markdown

davis commented Jul 6, 2015

ah i finally found why this is happening :D

@terrasoff
Copy link
Copy Markdown

not working... forced to switch to fork #1212

cristian-sima pushed a commit to cristian-sima/Wisply that referenced this pull request Oct 23, 2015
@isdampe
Copy link
Copy Markdown

isdampe commented Dec 20, 2016

+1 for merge...

@danielgasser
Copy link
Copy Markdown

Still not in master? How do I fix that and rebundle all files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.