update https://github.com/pre-commit/pre-commit-hooks to v5#12355
Merged
update https://github.com/pre-commit/pre-commit-hooks to v5#12355
Conversation
CodSpeed Performance ReportMerging #12355 will not alter performanceComparing Summary
|
adiroiban
approved these changes
Nov 6, 2024
Member
There was a problem hiding this comment.
Thanks for the update.. I think that we can merge this.
Using the PR ID as the issue ID should be fine.
The goal of a news-fragment is to make sure that we have taken into consideration the public impact of this change... and the result is that there is no public API impact... so we have .misc
I see another warning in GitHub Actions... I guess that this means that we should stop using macoS12 and look at updating to macos13
3.8-macos-12-default-tests
A brownout will take place on November 11, 14:00 UTC - November 12, 00:00 UTC to raise awareness of the upcoming macOS-12 environment removal. For more details, see https://github.com/actions/runner-images/issues/10721
Member
Author
|
Thanks for the review. I'll note that afaik macOS 13 is the last Intel one (at least from GitHub Actions). #12356 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
avoid this warning
https://github.com/twisted/twisted/actions/runs/11704390335/job/32596743062?pr=12354#step:5:182
note no warning at https://github.com/twisted/twisted/actions/runs/11704630183/job/32597537632?pr=12355#step:5:178
Fixes #
Add a few words about why this PR is needed and what is its scope.
If the associate ticket(s) fully explain the need you can just refer to it/them.
Add any comments about trade-offs (if any) made in this PR and the reasoning behind them.
Add mentions of things that are not covered here and are planed to be done in separate PRs.
Contributor Checklist:
This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.
Below is a non-exhaustive list (as a reminder):
please review.Our bot will trigger the review process, by applying the pending review label
and requesting a review from the Twisted dev team.