Run GitHub action test on macOS 13 on Intel.#12356
Merged
Conversation
CodSpeed Performance ReportMerging #12356 will not alter performanceComparing Summary
|
Member
Author
|
https://github.com/twisted/twisted/actions/runs/11706690529/job/32604433424 looks as if we actually don't work on macOS ARM? I'll remove that from here to get off the deprecated runners. |
adiroiban
approved these changes
Nov 6, 2024
Member
adiroiban
left a comment
There was a problem hiding this comment.
Thank you very much. All good.
https://github.com/twisted/twisted/actions/runs/11706690529/job/32604433424 looks as if we actually don't work on macOS ARM? I'll remove that from here to get off the deprecated runners.
I am not sure if this is ARM issue or macOS 15 issue.
We can look into arm + macos15 in a separate PR.
also, I think that we can keep only 2 jobs for macoS
- Oldes macOS on Intel
- Newes macOS on ARM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
afaik macOS 13 is the last tag for macOS on Intel in GitHub Actions free public runners.
https://github.com/twisted/twisted/actions/runs/11704630183?pr=12355
Fixes #
Add a few words about why this PR is needed and what is its scope.
If the associate ticket(s) fully explain the need you can just refer to it/them.
Add any comments about trade-offs (if any) made in this PR and the reasoning behind them.
Add mentions of things that are not covered here and are planed to be done in separate PRs.
Contributor Checklist:
This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.
Below is a non-exhaustive list (as a reminder):
please review.Our bot will trigger the review process, by applying the pending review label
and requesting a review from the Twisted dev team.