Deprecate Environment::mergeGlobals()#4283
Conversation
…abus) This PR was merged into the 5.4 branch. Discussion ---------- [TwigBridge] Avoid calling deprecated mergeGlobals() | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Follows twigphp/Twig#4283 | License | MIT `getGlobals()` is documented as the official replacement for `mergeGlobals()` despite being flagged ``@internal``. I've left a comment on the upstream PR. Commits ------- 2883331 [TwigBridge] Avoid calling deprecated mergeGlobals()
|
@fabpot It is a bit unfortunate, that this was merged while Symfony TwigBridge has not yet been tagged. Given this is included in the security release 3.14, we cannot upgrade because of deprecated usage in TwigBridge:
Would it be an idea to get this tagged? symfony/symfony#58207 I know one solution could be to turn off detecting of indirect deprecations, but it's super valuable to detect deprecations in vendor and help to get those fixed. |
|
@ruudk There's no shame in temporarily installing a dev snapshot of the Twig Bridge if that solves a problem for you. |
|
True. But I'm raising it, as there might be more people getting this "problem". |
No description provided.