[TwigBridge] Avoid calling deprecated mergeGlobals()#58207
Merged
derrabus merged 1 commit intosymfony:5.4from Sep 9, 2024
Merged
[TwigBridge] Avoid calling deprecated mergeGlobals()#58207derrabus merged 1 commit intosymfony:5.4from
derrabus merged 1 commit intosymfony:5.4from
Conversation
Member
Author
|
The test failure on high-deps is the test suite of Symfony 4.4 failing with current Symfony 5.4 deps and Twig 3.12 and later. These failures happen without my changes as well. |
xabbuh
approved these changes
Sep 9, 2024
This was referenced Sep 21, 2024
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getGlobals()is documented as the official replacement formergeGlobals()despite being flagged@internal. I've left a comment on the upstream PR.