Skip to content

Add return types missed in #4211#4213

Merged
fabpot merged 1 commit into
twigphp:4.xfrom
smnandre:fix/missing-types-doc
Aug 17, 2024
Merged

Add return types missed in #4211#4213
fabpot merged 1 commit into
twigphp:4.xfrom
smnandre:fix/missing-types-doc

Conversation

@smnandre

Copy link
Copy Markdown
Contributor

Complete #4211 (sorry)

I forgot to update the docs, and found some others in RuntimeLoader(s)

@fabpot fabpot force-pushed the fix/missing-types-doc branch from d8eefaa to 21f08dc Compare August 17, 2024 21:34
@fabpot

fabpot commented Aug 17, 2024

Copy link
Copy Markdown
Contributor

Thank you @smnandre.

@fabpot fabpot merged commit 8c090c3 into twigphp:4.x Aug 17, 2024
@smnandre

Copy link
Copy Markdown
Contributor Author

@fabpot

Do we need or plan to do it for all missing return types in the Twig 4.x codebase ?

There is still a lot of them (with or without @return tags)

Examples:

  • TemplateWrapper:unwrap (@private)
  • ExpressionParser::parseArrow (private)
  • ExpressionParser::parseStringExpression (public)
  • Template::renderParentBlock() (@internal)
  • Environment::getCache() (public)

@fabpot

fabpot commented Aug 19, 2024

Copy link
Copy Markdown
Contributor

I suppose we can start with everything private (arg and return types), maybe everything @internal as well?

@smnandre

Copy link
Copy Markdown
Contributor Author

@fabpot started this here #4218

Most of concerned methods are in fact public or protected :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants