Add private types on 4.x#4218
Conversation
|
Remaining non-typed arguments inherit their "non-types" from protected or public methods, not sure what to do there Example in abstract protected function formatTime(Profile $profile, $percent): string;
private function dumpProfile(Profile $profile, $prefix = '', $sibling = false): string |
|
Actually, types on all private APIs could be added in the 3.x branch |
|
So i should target 3.x for this one @stof right ? And then deal with |
ceaf8ea to
1864c38
Compare
|
(is there something like a "fabbot_ignore"? to prevent false-positive ? asking more generally than for this PR) |
|
Let's not bother with 3.x. |
|
So this seems ok for a first step. Let's create another one for @internal function/methods if you're ok ? Because here there may be a "soft-conflict" between the signature ( |
1864c38 to
72bbe48
Compare
|
Thank you @smnandre. |
|
@smnandre there is no conflict in your code snippet. The code is not passing null to |
|
Wow... let's just attribute it to today's emotions. ;) |
(WIP but i open to gather early feedback / comments)
Objective: add missing types
Maybe "@internal" then