Add missing return types in 4.0#4211
Merged
Merged
Conversation
Kocal
reviewed
Aug 17, 2024
Contributor
|
@smnandre Yes, we should do it on |
Contributor
Author
|
I made a pass on them and think it's good :) |
967fe81 to
470965f
Compare
Contributor
|
Thank you @smnandre. |
Contributor
Author
|
Arf I found others while checking sorry .... in code runtimeloader + docs. I'll open another PR :| |
fabpot
pushed a commit
to smnandre/Twig
that referenced
this pull request
Aug 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert the removal of return types done in #3156
Should i propagate to
extrapackages in the same PR ?