Skip to content

Fix date inputs heights in safari#30353

Merged
MartijnCuppens merged 1 commit intomasterfrom
master-mc-remove-appearance-from-date-input
Apr 1, 2020
Merged

Fix date inputs heights in safari#30353
MartijnCuppens merged 1 commit intomasterfrom
master-mc-remove-appearance-from-date-input

Conversation

@MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Mar 6, 2020

It seems #11266 is solved in the meantime and this was causing the inputs to shrink (date & time inputs):
image

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner March 6, 2020 16:27
@MartijnCuppens MartijnCuppens mentioned this pull request Mar 6, 2020
Merged
@XhmikosR
Copy link
Member

XhmikosR commented Mar 6, 2020

@MartijnCuppens which iOS versions did you test?

bootstrap/.browserslistrc

Line 10 in d79830c

iOS >= 10

@mdo
Copy link
Member

mdo commented Mar 6, 2020

Tangent, but saw the comment and figured I'd look up iOS distribution: https://developer.apple.com/support/app-store/. We can probably move to iOS 12+ given the browser share there. v4 covers us on older versions.

@ysds
Copy link
Contributor

ysds commented Mar 7, 2020

@MartijnCuppens Could you create before and after test cases?

@MartijnCuppens
Copy link
Member Author

MartijnCuppens commented Mar 7, 2020

Before

ios13:
image
ios12:
image
ios11:
image
ios9:
image

After

ios13:
image
ios12:
image
ios11:
image
ios9:
image

I can't reproduce the initial issue from back in 2013.

@XhmikosR
Copy link
Member

XhmikosR commented Mar 7, 2020

Shouldn't this be also backported?

MartijnCuppens added a commit that referenced this pull request Mar 7, 2020
@MartijnCuppens
Backport #30353
9425f6f
@MartijnCuppens MartijnCuppens mentioned this pull request Mar 7, 2020
Merged
@MartijnCuppens
Copy link
Member Author

MartijnCuppens commented Mar 7, 2020

Yes, made a separate PR since reboot changed a lot in v5

@ysds
Copy link
Contributor

ysds commented Mar 8, 2020

@MartijnCuppens Do you intend that this affect input style with .form-control class?

Before: https://codepen.io/fellows3/pen/BaNmvvN

image

After: https://codepen.io/fellows3/pen/RwPjEeO

image

@MartijnCuppens MartijnCuppens changed the title Remove appearance from date inputs Fix date inputs heights in safari Mar 10, 2020
@MartijnCuppens MartijnCuppens force-pushed the master-mc-remove-appearance-from-date-input branch from a2e903c to 62acca4 Compare March 10, 2020 21:11
@MartijnCuppens
Copy link
Member Author

MartijnCuppens commented Mar 10, 2020

In that case we should only change the appearance for .form-controls. I now pushed some changes and set the height of the ::-webkit-date-and-time-value pseudo selector to prevent it from collapsing.

ysds
ysds reviewed Mar 14, 2020
View reviewed changes
MartijnCuppens added a commit that referenced this pull request Mar 31, 2020
@MartijnCuppens
Backport #30353
68dd30d 
Remove appearance from date inputs
XhmikosR added a commit that referenced this pull request Apr 1, 2020
@MartijnCuppens @XhmikosR
Backport #30353 (#30361)
1b575c2 
Remove appearance from date inputs

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
@MartijnCuppens MartijnCuppens force-pushed the master-mc-remove-appearance-from-date-input branch from 9828643 to ccab761 Compare April 1, 2020 06:25
@MartijnCuppens MartijnCuppens merged commit 6663faa into master Apr 1, 2020
@MartijnCuppens MartijnCuppens deleted the master-mc-remove-appearance-from-date-input branch April 1, 2020 06:30
ashfahan added a commit to fluid-framework/Fluid that referenced this pull request Apr 23, 2020
@ashfahan
🆙 📦 Updates from bootstrap reboot
a7bdca7 
twbs/bootstrap#30323
twbs/bootstrap#30340
twbs/bootstrap#30345
twbs/bootstrap#30353
twbs/bootstrap#30269
@mdo mdo mentioned this pull request May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ysds ysds ysds approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

css v5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MartijnCuppens @XhmikosR @mdo @ysds