Skip to content

Fix <legend> wrapping bug#30345

Merged
XhmikosR merged 1 commit intomasterfrom
master-mc-legend-fix
Mar 21, 2020
Merged

Fix <legend> wrapping bug#30345
XhmikosR merged 1 commit intomasterfrom
master-mc-legend-fix

Conversation

@MartijnCuppens
Copy link
Member

Fixes #29712. Alternative for #29831 which works in Edge.

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner March 6, 2020 12:49
@MartijnCuppens MartijnCuppens changed the title Fix wrapping bug Fix <legend> wrapping bug Mar 6, 2020
@ysds
Copy link
Contributor

ysds commented Mar 8, 2020

What is a reason not to use display: table like normalize.css?

@mdo
Copy link
Member

mdo commented Mar 10, 2020

Might be imagining it, but I feel like we ran into an issue with the table approach? Can't remember...

@MartijnCuppens
Copy link
Member Author

MartijnCuppens commented Mar 10, 2020

The reason is ease of theming:
v4: https://codepen.io/MartijnCuppens/pen/vYOdBeo (border issue)
v5: https://codepen.io/MartijnCuppens/pen/VwLQZWN

@XhmikosR
Copy link
Member

@MartijnCuppens can you rebase this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flex container doesn't display correctly next to a legend

4 participants