Skip to content

reset carousel touch delta x to prevent click transformed in swipe#28558

Merged
XhmikosR merged 2 commits into
masterfrom
v4-jo-fix-carousel-click-slide
Mar 27, 2019
Merged

reset carousel touch delta x to prevent click transformed in swipe#28558
XhmikosR merged 2 commits into
masterfrom
v4-jo-fix-carousel-click-slide

Conversation

@Johann-S

@Johann-S Johann-S commented Mar 26, 2019

Copy link
Copy Markdown
Member

Fixes: #28546, #28070

@Johann-S Johann-S requested a review from a team as a code owner March 26, 2019 09:51
@Johann-S Johann-S requested a review from patrickhlauke March 26, 2019 09:57
@XhmikosR XhmikosR changed the base branch from v4-dev-xmr to master March 26, 2019 10:06
@XhmikosR XhmikosR force-pushed the v4-jo-fix-carousel-click-slide branch from 1d3a75f to 4fb7d20 Compare March 26, 2019 10:09
@XhmikosR XhmikosR force-pushed the v4-jo-fix-carousel-click-slide branch from 4fb7d20 to e883652 Compare March 26, 2019 10:14

@patrickhlauke patrickhlauke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, and seems to be working fine now

@XhmikosR

Copy link
Copy Markdown
Member

Cool, I'm gonna merge it cherry pick it in my #28505

@XhmikosR XhmikosR merged commit 1752add into master Mar 27, 2019
@XhmikosR XhmikosR deleted the v4-jo-fix-carousel-click-slide branch March 27, 2019 12:37
@mdo mdo mentioned this pull request Jul 22, 2019
tmorehouse added a commit to bootstrap-vue/bootstrap-vue that referenced this pull request Jul 22, 2019
jacobmllr95 pushed a commit to bootstrap-vue/bootstrap-vue that referenced this pull request Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

carousel is sliding on ios when clicking whitout controls

3 participants