Skip to content

fix(carousel): reset touchDeltaX to prevent click transformed in swipe#3734

Merged
jacobmllr95 merged 1 commit into
devfrom
tmorehouse/carousel
Jul 22, 2019
Merged

fix(carousel): reset touchDeltaX to prevent click transformed in swipe#3734
jacobmllr95 merged 1 commit into
devfrom
tmorehouse/carousel

Conversation

@tmorehouse

Copy link
Copy Markdown
Member

Describe the PR

Based on twbs/bootstrap#28558

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse requested a review from jacobmllr95 July 22, 2019 19:23
@tmorehouse tmorehouse added the PR: Patch Requires patch version bump label Jul 22, 2019
@codecov

codecov Bot commented Jul 22, 2019

Copy link
Copy Markdown

Codecov Report

Merging #3734 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3734   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files         223      223           
  Lines        4378     4378           
  Branches     1235     1235           
=======================================
  Hits         4347     4347           
  Misses         25       25           
  Partials        6        6
Impacted Files Coverage Δ
src/components/carousel/carousel.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62c66bb...6541173. Read the comment docs.

@jacobmllr95 jacobmllr95 merged commit 0e54839 into dev Jul 22, 2019
@jacobmllr95 jacobmllr95 deleted the tmorehouse/carousel branch July 22, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Patch Requires patch version bump Type: Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants