Only disable pointer-events on disabled <a> btns#16092
Conversation
<a> doesn't support the `[disabled]` attribute, so `a.btn.disabled` simulates it using `pointer-events: none`. However, this is unnecessary for <button>s and <input>s, and also prevents their `[disabled]` cursor from displaying. [skip sauce] [skip validator]
|
Sounds reasonable to me I suppose. |
Only disable pointer-events on disabled <a> btns
|
I think |
|
@steph643 We basically don't recommend using the |
|
@cvrebert, thanks a million. I had this mistake in several places in my code. |
|
In our local builds I've chosen to add this rule back until we've been able to audit our existing codebase as we've been relying on the effect of I understand the reason for this specific issue, but this type of breaking change seems awfully severe for a bugfix release—whereas Given the benefit of this backwards-incompatibility seems limited to styling on mouse hover events, I'd argue that this change would be suitable for a major release (4.0) and not for a bugfix or even minor version bump where compatibility is to be preserved. |
|
FWIW, our docs only show/mention usage of I will see about adding a linter for |
Remove inline CSS after twbs/bootstrap#16092
|
Is it safe to override the or will I get unexpected behavior? I rather like having the |
|
It's a breaking change! Why was it merged to v3?? Now I have to rewrite some code :( |
Fixes #16088.
Applying
pointer-events: noneto non-<a>buttons is unnecessary and prevents their[disabled]:hoverstyles, in particular theircursor, from applying.