Skip to content
This repository was archived by the owner on Mar 12, 2020. It is now read-only.

Remove inline CSS adding#166

Merged
1000hz merged 3 commits into
1000hz:masterfrom
balcsida:patch-1
Jul 14, 2015
Merged

Remove inline CSS adding#166
1000hz merged 3 commits into
1000hz:masterfrom
balcsida:patch-1

Conversation

@balcsida

Copy link
Copy Markdown
Contributor

It is unnecessary to add pointer-events and cursor as inline css, the disable class works pretty well.

balcsida added 3 commits July 14, 2015 15:08
Removed CSS add
Removed "disable css" adding
@1000hz

1000hz commented Jul 14, 2015

Copy link
Copy Markdown
Owner

I have to re-enable pointer-events because Bootstrap sets .disabled buttons to pointer-events: none. This prevents the form from revealing all the fields that are invalid.

@1000hz 1000hz closed this Jul 14, 2015
@balcsida

Copy link
Copy Markdown
Contributor Author

Not anymore: https://github.com/twbs/bootstrap/releases/tag/v3.3.5
"#16092: Only disable pointer-events on disabled .btns"

@1000hz

1000hz commented Jul 14, 2015

Copy link
Copy Markdown
Owner

Oh! Well then. Thanks!

@1000hz 1000hz reopened this Jul 14, 2015
1000hz added a commit that referenced this pull request Jul 14, 2015
@1000hz 1000hz merged commit 1c17685 into 1000hz:master Jul 14, 2015
@balcsida balcsida deleted the patch-1 branch July 14, 2015 15:52
@balcsida balcsida restored the patch-1 branch July 14, 2015 15:53
@balcsida balcsida deleted the patch-1 branch July 14, 2015 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants