Remove translate3d from navbar#14667
Merged
Merged
Conversation
Collaborator
|
I'll try if switching to |
Collaborator
|
Seems as though Safari 7.1 fixed #14254 or at least I'm no longer able to reproduce. |
Collaborator
|
Yeah, so far we've only had the one, pretty obscure issue with modals (#14124), so I don't see any particular need to remove it there yet. |
6910121 to
f540569
Compare
Member
Author
|
Legit. Just (force) pushed up the change to make this only for navbars. |
Collaborator
|
|
Collaborator
|
Just keep in mind that we'll need to close #14603 manually because of GitHub not respecting a list of issues to close in commit messages. hint hint |
Collaborator
|
Reverts the navbar portion of #13649. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14227 and #14603.
Due to ongoing problems with iOS rendering and unexpected clashes when folks are customizing Bootstrap, we're dropping the
translate3don modals and navbars. This PR leaves the ones in the carousel though for those smoother transitions (I don't think anyone's complained about those).Only question I have: should we remove it from modals, or just navbars?
/cc @cvrebert @hnrch02