Skip to content

Repaint Fixes When Scrolling#13649

Merged
mdo merged 1 commit into
twbs:masterfrom
ItsJonQ:repaint-fixes-2
Jun 8, 2014
Merged

Repaint Fixes When Scrolling#13649
mdo merged 1 commit into
twbs:masterfrom
ItsJonQ:repaint-fixes-2

Conversation

@ItsJonQ

@ItsJonQ ItsJonQ commented May 21, 2014

Copy link
Copy Markdown
Contributor

Heya guys!

Here's my 2nd attempt at this. Thanks again for being so patient with my first try.

Ideally, translateZ(0) would work the best in the spots that I've added the vendor-prefix mixin of .translate3d() as it has IE9 support. Based on feedback from my first PR, I avoided adding a mixin specifically for translateZ.

The translate3d fix for .modal is tricky. It effectively fixes repaints on scroll.. but it might be problematic for IE 8-9.

Thanks!

@cvrebert cvrebert added the css label May 21, 2014
@cvrebert cvrebert added this to the v3.2.0 milestone May 21, 2014
@cvrebert cvrebert mentioned this pull request May 21, 2014
@mdo

mdo commented May 21, 2014

Copy link
Copy Markdown
Member

The translate3d fix for .modal is tricky. It effectively fixes repaints on scroll.. but it might be problematic for IE 8-9.

I can check that out—I've got a couple VMs locally to peep this in before merging.

@mdo

mdo commented May 21, 2014

Copy link
Copy Markdown
Member

Thanks again for being so patient with my first try.

And no, thank you for not giving up <3.

@ItsJonQ

ItsJonQ commented May 21, 2014

Copy link
Copy Markdown
Contributor Author

@mdo Dawww, thanks dude :). You're the best (around. Nothing's ever gonna keep you down..) Hopefully everything checks out!

mdo added a commit that referenced this pull request Jun 8, 2014
@mdo mdo merged commit 3ee5542 into twbs:master Jun 8, 2014
@mdo mdo mentioned this pull request Jun 8, 2014
@mdo

mdo commented Jun 8, 2014

Copy link
Copy Markdown
Member

Thanks!

@cvrebert

cvrebert commented Oct 3, 2014

Copy link
Copy Markdown
Collaborator

So, for folks keeping score at home, these changes ended up being reverted due to Safari bugs, bad-looking fonts on Windows, and navbar customization problems.
Isn't the Web great? 😬

@ItsJonQ

ItsJonQ commented Oct 3, 2014

Copy link
Copy Markdown
Contributor Author

@cvrebert No problem! Sorry for all the trouble this guy caused :(.

@jmcbee

jmcbee commented Oct 8, 2014

Copy link
Copy Markdown

hi @ItsJonQ can you show the before and after timeline of this? Would be awesome! Too bad it conflicts with other stuffs.

@ItsJonQ

ItsJonQ commented Oct 8, 2014

Copy link
Copy Markdown
Contributor Author

Heya @fbm-static ,

Sure! I'd be more than happy to do that.. but I'm not sure where to find that info (sorry!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants