Update to Kotlin 1.8.0#344
Merged
tschuchortdev merged 6 commits intotschuchortdev:masterfrom Mar 5, 2023
Merged
Conversation
Contributor
Author
|
Needs an update to 1.8.10. @tschuchortdev I'm sorry to ping you directly, but is there a chance we could get this reviewed and merged? I know there are a few projects waiting on it. Please let me know, thanks. |
|
have to halt testing until this is fixed :( |
benjamin-bader
added a commit
to microsoft/thrifty
that referenced
this pull request
Feb 21, 2023
kotlin-compile-testing does not currently support Kotlin 1.8. There is a [pull request](tschuchortdev/kotlin-compile-testing#344) that has been open since December 2022, but it has not been acknowledged at all by the maintainer. Indeed the maintainer has been AWOL since August 2022. This PR comments out the uses of this library; we may end up forking it to get unblocked in the next few months.
|
@tschuchortdev are you able to help land this PR to unblock codebases from adopting Kotlin 1.8? |
|
Thanks for landing this and cutting a new release @tschuchortdev! Much appreciated! |
Owner
|
I should be the one thanking @3flex and @ZacSweers for their help in supporting the new compiler version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #336
Closes #333
Closes #328
Closes #329