Skip to content

Bump Kotlin to 1.8.10, comment out should-compiles#530

Merged
benjamin-bader merged 1 commit intomicrosoft:masterfrom
benjamin-bader:update-kotlin
Feb 21, 2023
Merged

Bump Kotlin to 1.8.10, comment out should-compiles#530
benjamin-bader merged 1 commit intomicrosoft:masterfrom
benjamin-bader:update-kotlin

Conversation

@benjamin-bader
Copy link
Copy Markdown
Collaborator

kotlin-compile-testing does not currently support Kotlin 1.8. There is a pull
request
that has been open since December 2022, but it has not been acknowledged at all by the maintainer. Indeed the maintainer has been AWOL since August 2022. This PR comments out the uses of this library; we may end up forking it to get unblocked in the next few months.

kotlin-compile-testing does not currently support Kotlin 1.8.  There is
a [pull
request](tschuchortdev/kotlin-compile-testing#344)
that has been open since December 2022, but it has not been acknowledged
at all by the maintainer.  Indeed the maintainer has been AWOL since
August 2022.  This PR comments out the uses of this library; we may end
up forking it to get unblocked in the next few months.
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #530 (a4eb43a) into master (4b427af) will increase coverage by 59.68%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master     #530       +/-   ##
=============================================
+ Coverage          0   59.68%   +59.68%     
- Complexity        0      883      +883     
=============================================
  Files             0       70       +70     
  Lines             0     7040     +7040     
  Branches          0     1035     +1035     
=============================================
+ Hits              0     4202     +4202     
- Misses            0     2534     +2534     
- Partials          0      304      +304     
Impacted Files Coverage Δ
...kotlin/com/microsoft/thrifty/schema/ServiceType.kt 59.67% <0.00%> (ø)
...ain/kotlin/com/microsoft/thrifty/schema/Program.kt 89.23% <0.00%> (ø)
...otlin/com/microsoft/thrifty/schema/Requiredness.kt 100.00% <0.00%> (ø)
...crosoft/thrifty/schema/parser/ConstValueElement.kt 94.44% <0.00%> (ø)
.../microsoft/thrifty/gradle/ThriftyGradlePlugin.java 10.34% <0.00%> (ø)
.../com/microsoft/thrifty/schema/render/ThriftSpec.kt 0.00% <0.00%> (ø)
...java/com/microsoft/thrifty/testing/TestClient.java 60.46% <0.00%> (ø)
...main/kotlin/com/microsoft.thrifty.gen/TypeNames.kt 85.00% <0.00%> (ø)
...tlin/com/microsoft/thrifty/schema/ErrorReporter.kt 92.85% <0.00%> (ø)
.../kotlin/com/microsoft/thrifty/schema/StructType.kt 46.29% <0.00%> (ø)
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@benjamin-bader benjamin-bader merged commit 9b1831d into microsoft:master Feb 21, 2023
@benjamin-bader benjamin-bader deleted the update-kotlin branch February 21, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants