Introduce find_unlinked_contexts_in_context() helper#378
Merged
trishume merged 2 commits intoOct 17, 2021
Conversation
To make the upcoming diff for trishume#374 easier to read.
Collaborator
Author
|
I would like to give an overview of the journey ahead of us. The plan is to split up the prototype quality code in the PoC into 6 incremental steps. One PR per step, with the code turned into production quality code. The steps are:
And then, we're done ✅ |
trishume
approved these changes
Oct 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glad to hear you liked my PoC for lazy-loading syntaxes! No worries about having a busy life :)
Here comes another PR. This one is pretty simple. But it will make the upcoming work and diff for #374 easier to do and read.
The code can be further simplified and refactored, but spare time is limited, and at this point I'd prefer to prioritize getting lazy-loading production ready.
First commit splits out a helper function (ignore white space when diffing to get a nice diff), and the second commit runs cargo fmt on the new helper function.