Rename contexts in SyntaxReference to context_ids#379
Merged
Conversation
contexts in SyntaxRefrence to context_idscontexts in SyntaxReference to context_ids
We will later split up and move `contexts` from `SyntaxSet` to `SyntaxReference`s. If we don't do this renaming, there will be a name clash. Unless we call the new field something else of course, but that would only be confusing.
08c9e88 to
200dd70
Compare
trishume
approved these changes
Oct 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will later split up and move
contextsfromSyntaxSettoSyntaxReferences. If we don't do this renaming, there will be a name clash.Unless we call the new field something else of course, but that would only be
confusing.
Note that
bincodedoes not serialize field names, so the existing packdumps are still valid.For an overview of where this PR fits in the bigger picture, see this updated comment: #378 (comment)