Build: Define default options only on "default"#138
Merged
jonjoliver merged 1 commit intotrendmicro:masterfrom Oct 8, 2024
Merged
Build: Define default options only on "default"#138jonjoliver merged 1 commit intotrendmicro:masterfrom
jonjoliver merged 1 commit intotrendmicro:masterfrom
Conversation
(i.e. when no related options are specified). With this, full hash (256 bucket variant) will compile just by -DTLSH_BUCKETS_256=1. It causes an error due to a failure to track with other changes on the version 4.0.0 on min hash (48 buckets variant) so this commit also fixes this issue.
Collaborator
jonjoliver
approved these changes
Sep 19, 2024
Closed
jonjoliver
pushed a commit
to jonjoliver/tlsh
that referenced
this pull request
Oct 8, 2024
<PRE>
08/10/2024
Merge pull request trendmicro#146 - Remove call to sprintf() to avoid warnings
Merge pull request trendmicro#141 - py_ext: use PyVarObject_HEAD instead of PyObject_HEAD_INIT
Merge pull request trendmicro#138 - Build: Define default options only on "default"
Merge pull request trendmicro#136 - Bug Fix+Portability: Improve portability by integral division
</PRE>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit sets default options only when no related options are specified.
With this, full hash (256 bucket variant) will compile just by
-DTLSH_BUCKETS_256=1.Just fixing CMakeLists.txt caused an error due to a failure to track with other changes on the version 4.0.0 on min hash (48 buckets variant) so this commit also fixes this issue.