adapt to new rust lints and tweak ci#4249
Conversation
|
Oh dear, looks like that's a bug in cargo itself. |
|
rust-lang/rust#137640 for the lint failure. As for the failed test, I can't look too closely now but I suspect it's due to the recent changes in tree-sitter-rust: tree-sitter/tree-sitter-rust#254 Edit: I guess we'll have to wait until cargo's nightly channel is fixed. |
0e16fee to
6990915
Compare
|
Again, I'm wondering why you're YOLOing nightly Rust in CI... |
¯_(ツ)_/¯ I think amaanq likes to stay on top of the nightly lints. Maybe it would be better to run the nightly lints as a separate job and use stable for everything else? That way any new lint failures are visible, but issues in the nightly toolchain won't be a blocker like here. |
|
Yes, that would be reasonable (and not mark it as required). |
302e853 to
7bb4ec9
Compare
7bb4ec9 to
437fa81
Compare
437fa81 to
7966d7e
Compare
|
Something something first try? Changes now include fixes for two new lints, test updates to reflect changes in tree-sitter-rust, as well as moving the nightly clippy invocation to a separate job that doesn't cause the action to fail. I'm not sure why rust-lang/rust#137640 is closed as completed, but I'm still seeing the crash with nightly. It might be worth opening a separate issue. |
|
Successfully created backport PR for |
Fixes the CI failure discussed in #4244
CC @clason