fix(web): provide type in the exports#4244
Conversation
When using TypeScript projects using other module settings than CommonJs, the types were not correctly exposed, and the compilation failed. This adds the types path to the exports so compilation works for `module: NodeNext` and other variants. (cherry picked from commit f95e0e3)
|
Didn't see this when I opened #4229. But I'm curious what this PR looks like when run through arethetypeswrong. /cc @clason |
|
Answering my own question: this is an improvement over the status quo, but I'm going to keep #4229 open in hopes of improving this further. 
|
|
Note that this is a backport of a PR that got merged to (and passed CI on) (Or, if the fixup is small, paste here as a diff and I'll add it.) |
|
@clason It's not a failure. This backport will improve the status quo for TypeScript users. Feel free to land it whenever. It's also technically incorrect for a couple of reasons that are addressed in #4229, so I was mainly asking out loud whether #4229 was worth closing — and the answer is no. #4229 can be reviewed at someone's leisure and landed whenever; this backport reduces the urgency. |
|
I mean the CI failure here. I don't feel comfortable merging a PR with a failing check that I am not absolutely sure is a flake. |
|
It looks like the failure is just due to a new clippy lint from the 1.85 release. I can open a PR tonight to have it fixed on master, but that should be fine to merge. |
|
We might wish to check other recent PRs for backporting then and consider another 0.25.3 release. |
Description
Backport of #4185 to
release-0.25.