fix(web): provide type in the exports#4185
Merged
amaanq merged 1 commit intotree-sitter:masterfrom Feb 8, 2025
Merged
Conversation
When using TypeScript projects using other module settings than CommonJs, the types were not correctly exposed, and the compilation failed. This adds the types path to the exports so compilation works for `module: NodeNext` and other variants.
Contributor
Author
Member
|
CI failure is unrelated (and fixed by #4192), thanks! |
amaanq
approved these changes
Feb 8, 2025
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using TypeScript projects using other module settings than CommonJs, the types were not correctly exposed, and the compilation failed.
This adds the types path to the exports so compilation works for
module: NodeNextand other variants.I've tested this with a test project using TypeScript and several
moduleandmoduleResolutioncombinations.