parse turbofish patterns#254
Merged
maxbrunsfeld merged 2 commits intotree-sitter:masterfrom Feb 27, 2025
Merged
Conversation
maxbrunsfeld
requested changes
Feb 27, 2025
Contributor
maxbrunsfeld
left a comment
There was a problem hiding this comment.
Thanks for adding this, and for the great investigation of where we don't match rustc. I left a name change suggestion.
b99a024 to
9d69c7d
Compare
maxbrunsfeld
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up on parts of #229.
i made my own list of rustc tests that could be parsed by rustc, but couldn't be parsed with tree-sitter. with this change, here is the difference in that list:
diff
i am not entirely sure when it is appropriate to do a
fieldin tree-sitter, but i decided to put thetype_argumentsin afieldlike thegeneric_type_with_turbofishdoes, but not wrap the identifier in it, like all of the other patterns do.